Delete STS roles regularly #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grusev
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
phoebusm
requested changes
Apr 28, 2025
| print(f"Role {role} is from today, skipping it.") | ||
| else: | ||
| print(f"{i} DELETE role {role}. An old role") | ||
| delete_role(client, role) |
There was a problem hiding this comment.
Users should be cleaned up as well.
Please refer to def real_s3_sts_clean_up
There was a problem hiding this comment.
addressed! We had >3000 active users!
|
I wonder why the roles not being cleaned up by |
phoebusm
reviewed
Apr 28, 2025
poodlewars
approved these changes
May 9, 2025
phoebusm
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
Due to limitation of STS roles number we should constantly do cleaning of failed to delete roles. The PR contains a scheduled job that would do that every Sa. The python script can also be executed at any time and will delete only roles created prior of today, leaving all currently running jobs unaffected
As roles cannot be guaranteed to be cleaned after tests execution due to many factors, we should take them out on regular bases, and perhaps this is the quickest and most reliable approach
Any other comments?
Checklist
Checklist for code changes...