Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake improvement #348

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

JohanMabille
Copy link
Collaborator

Addresses the comments from apache/iceberg-cpp#44 (comment)

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (532bf48) to head (79aec32).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   90.34%   90.24%   -0.11%     
==========================================
  Files          84       84              
  Lines        6516     6531      +15     
==========================================
+ Hits         5887     5894       +7     
- Misses        629      637       +8     
Flag Coverage Δ
unittests 90.24% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohanMabille JohanMabille force-pushed the cmake_improvement branch 3 times, most recently from 6d92a49 to 4b2a75f Compare February 11, 2025 13:46
@JohanMabille JohanMabille merged commit 38e43a9 into man-group:main Feb 11, 2025
69 of 71 checks passed
@JohanMabille JohanMabille deleted the cmake_improvement branch February 11, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants