Adds support for the A5 dggs#71
Merged
Merged
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Closes #68 by adding support for the A5 DGGS.
A5's
polygon_to_cellsoperates on a single ring, so the function is called multiple times in the presence of holes; the cells representing each hole are then subtracted from the primary set.The same function also returns a compacted set. Although it would be useful to retain the compacted set and avoid
uncompact, the issue in this case is that the user-defined parent resolution-prsets an upper bound on the compaction, but the function does not have a limit.Following the existing codebase, hex strings are used throughout. This should be avoided in the future, and a user should be able to specify the desired output type.