Refactor#72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring prompted by the addition of one more DGGS in an earlier PR. Various PEP changes, typo corrections, etc. included too. All tests pass.
Expanded tests to 63, up from 49. Added the following:
Test matrix holes (2 tests):
test_rhp_no_bisection,test_geohash_no_bisectionGeometry type coverage (2 tests):
test_h3_linestring— exercises the LineString branch end-to-end usingse-island-contours.gpkgtest_h3_point— exercises the Point branch usingse-island-height-pts.gpkgOutput validation (6 tests):
--parent-resreflected in partition dir names--geo point/--geo polygonproduce ageometrycolumn--geo pointcarries valid GeoParquet metadata--keep-attributesretains source columns (Name_2018,LCDB_UID)Error paths (4 tests):
parent_res >= resolutionraisesParentResolutionException--compactwithout--id_fieldraisesIdFieldErrorValueError-oraisesFileExistsError