Skip to content

Refactor#72

Merged
alpha-beta-soup merged 8 commits into
mainfrom
refactor
May 15, 2026
Merged

Refactor#72
alpha-beta-soup merged 8 commits into
mainfrom
refactor

Conversation

@alpha-beta-soup
Copy link
Copy Markdown
Member

@alpha-beta-soup alpha-beta-soup commented May 14, 2026

Refactoring prompted by the addition of one more DGGS in an earlier PR. Various PEP changes, typo corrections, etc. included too. All tests pass.

Expanded tests to 63, up from 49. Added the following:

Test matrix holes (2 tests):

  • test_rhp_no_bisection, test_geohash_no_bisection

Geometry type coverage (2 tests):

  • test_h3_linestring — exercises the LineString branch end-to-end using se-island-contours.gpkg
  • test_h3_point — exercises the Point branch using se-island-height-pts.gpkg

Output validation (6 tests):

  • Hive partition dirs named with correct parent-res prefix
  • Explicit --parent-res reflected in partition dir names
  • --geo point / --geo polygon produce a geometry column
  • --geo point carries valid GeoParquet metadata
  • --keep-attributes retains source columns (Name_2018, LCDB_UID)

Error paths (4 tests):

  • parent_res >= resolution raises ParentResolutionException
  • --compact without --id_field raises IdFieldError
  • Unknown DGGS key raises ValueError
  • Second run without -o raises FileExistsError

@alpha-beta-soup alpha-beta-soup merged commit 529a389 into main May 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant