Localize tab context menu items (en/ja)#34
Open
anthhub wants to merge 2 commits intomanaflow-ai:mainfrom
Open
Conversation
All hardcoded English strings in the tab context menu are now routed through Bundle.module localizedString, with corresponding entries in en.lproj and ja.lproj Localizable.strings. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughReplaced hard-coded tab context menu titles with localized key-based calls in TabItemView and added corresponding English, Japanese, Simplified Chinese, and Traditional Chinese localization entries. No public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Greptile SummaryThis PR completes the localization of the tab context menu by replacing every hardcoded English string with
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["contextMenuContent (SwiftUI ViewBuilder)"] --> B["localizedContextButton(key, defaultValue, action)"]
B --> C["Bundle.module.localizedString(forKey: key, value: defaultValue, table: nil)"]
C -->|"key found in Localizable.strings"| D["Localized String\n(e.g. 'タブ名を変更…' / 'Rename Tab…')"]
C -->|"key missing"| E["defaultValue fallback\n(e.g. 'Rename Tab…')"]
D --> F["contextButton(resolvedTitle, action)"]
E --> F
F --> G{"shortcuts[action] set?"}
G -->|"yes"| H["Button(title).keyboardShortcut(shortcut)"]
G -->|"no"| I["Button(title)"]
Reviews (1): Last reviewed commit: "Localize tab context menu items with en/..." | Re-trigger Greptile |
3 tasks
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localizedContextButtoncalls that load translations fromBundle.moduleen.lproj/Localizable.stringsandja.lproj/Localizable.stringsTest plan
🤖 Generated with Claude Code
Summary by cubic
Localized the tab context menu and added English, Japanese, and Chinese (Simplified/Traditional) translations. Shortcuts and disabled states are unchanged.
localizedContextButtonviaBundle.module.en.lprojandja.lproj; addedzh-Hans.lprojandzh-Hant.lprojwith matching translations.Written for commit b70ba50. Summary will update on new commits.
Summary by CodeRabbit