feat: enhance logging for sample intersection to assist debugging "No gene exist." errors#24
Open
KaishinShaw wants to merge 1 commit into
Open
feat: enhance logging for sample intersection to assist debugging "No gene exist." errors#24KaishinShaw wants to merge 1 commit into
KaishinShaw wants to merge 1 commit into
Conversation
These changes allow users to easily debug data input issues by checking the log output.
Collaborator
|
Thank you for bringing this to our attention and make the edits accordingly! We are working on improving the software and will merge this changes in the future release! |
Contributor
|
Wow thank you so much. As @zixuanzhang mentioned, we have an updated version on another branch we're hoping to release soon, that also includes the features you developed here. Hoping to get them out before the holidays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the observability of the data preprocessing pipeline.
Currently, if a user encounters a "No gene exist." error, it is difficult to pinpoint whether the issue stems from:
Changes
logging.infostatements to report gene and sample counts after key steps:create_readydata(intersection of genotype, phenotype, and covariates).logging.warningif the dataset becomes empty immediately after intersection.logging.errorif the final gene count is zero.