Skip to content

HeaderMenu: use Menu trigger="click-hover" and other accessibility updates, and implement a basic responsive mobile example. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HeaderMenu: use Menu trigger="click-hover" and other accessibility updates, and implement a basic responsive mobile example. #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65d1b67
HeaderMenu: use Menu trigger="click-hover" and other accessibility up…
mg-aceik Jan 5, 2024
bc6e4b8
Merge branch 'master' into feature/headermenu
mg-aceik Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/HeaderMenu/HeaderMenu.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
}

.link {
display: block;
display: flex;
line-height: 1;
padding: rem(8px) rem(12px);
border-radius: var(--mantine-radius-sm);
Expand Down
72 changes: 59 additions & 13 deletions lib/HeaderMenu/HeaderMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
import { Menu, Group, Center, Burger, Container } from '@mantine/core';
import {
Container,
Group,
Button,
Menu,
Divider,
Center,
Burger,
Drawer,
ScrollArea,
rem,
Stack,
} from '@mantine/core';
import { useDisclosure } from '@mantine/hooks';
import { IconChevronDown } from '@tabler/icons-react';
import { MantineLogo } from '@mantinex/mantine-logo';
Expand Down Expand Up @@ -30,7 +42,7 @@ const links = [
];

export function HeaderMenu() {
const [opened, { toggle }] = useDisclosure(false);
const [drawerOpened, { toggle: toggleDrawer, close: closeDrawer }] = useDisclosure(false);

const items = links.map((link) => {
const menuItems = link.links?.map((item) => (
Expand All @@ -39,7 +51,15 @@ export function HeaderMenu() {

if (menuItems) {
return (
<Menu key={link.label} trigger="hover" transitionProps={{ exitDuration: 0 }} withinPortal>
<Menu
key={link.label}
trigger="click-hover"
position="bottom-start"
loop={false}
withinPortal={false}
trapFocus={false}
menuItemTabIndex={0}
>
<Menu.Target>
<a
href={link.link}
Expand Down Expand Up @@ -70,16 +90,42 @@ export function HeaderMenu() {
});

return (
<header className={classes.header}>
<Container size="md">
<div className={classes.inner}>
<MantineLogo size={28} />
<Group gap={5} visibleFrom="sm">
<>
<header className={classes.header}>
<Container size="md">
<div className={classes.inner}>
<MantineLogo size={28} />
<Group gap={5} visibleFrom="sm">
{items}
</Group>
<Burger opened={drawerOpened} onClick={toggleDrawer} hiddenFrom="sm" />
</div>
</Container>
</header>
<Drawer
opened={drawerOpened}
onClose={closeDrawer}
size="100%"
padding="md"
title="Navigation"
hiddenFrom="sm"
zIndex={1000000}
>
<ScrollArea h={`calc(100vh - ${rem(80)})`} mx="-md">
<Stack align="stretch">
<Divider my="sm" />

{items}
</Group>
<Burger opened={opened} onClick={toggle} size="sm" hiddenFrom="sm" />
</div>
</Container>
</header>

<Divider my="sm" />

<Group justify="center" grow pb="xl" px="md">
<Button variant="default">Log in</Button>
<Button>Sign up</Button>
</Group>
</Stack>
</ScrollArea>
</Drawer>
</>
);
}