Skip to content

fix: add preventDefault() in HeaderMegaMenu #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add preventDefault() in HeaderMegaMenu #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/HeaderMegaMenu/HeaderMegaMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ export function HeaderMegaMenu() {
<MantineLogo size={30} />

<Group h="100%" gap={0} visibleFrom="sm">
<a href="#" className={classes.link}>
<a href="#" className={classes.link} onClick={e => e.preventDefault()}>
Home
</a>
<HoverCard width={600} position="bottom" radius="md" shadow="md" withinPortal>
<HoverCard.Target>
<a href="#" className={classes.link}>
<a href="#" className={classes.link} onClick={e => e.preventDefault()}>
<Center inline>
<Box component="span" mr={5}>
Features
Expand All @@ -114,7 +114,7 @@ export function HeaderMegaMenu() {
<HoverCard.Dropdown style={{ overflow: 'hidden' }}>
<Group justify="space-between" px="md">
<Text fw={500}>Features</Text>
<Anchor href="#" fz="xs">
<Anchor href="#" fz="xs" onClick={e => e.preventDefault()}>
View all
</Anchor>
</Group>
Expand All @@ -140,10 +140,10 @@ export function HeaderMegaMenu() {
</div>
</HoverCard.Dropdown>
</HoverCard>
<a href="#" className={classes.link}>
<a href="#" className={classes.link} onClick={e => e.preventDefault()}>
Learn
</a>
<a href="#" className={classes.link}>
<a href="#" className={classes.link} onClick={e => e.preventDefault()}>
Academy
</a>
</Group>
Expand All @@ -169,7 +169,7 @@ export function HeaderMegaMenu() {
<ScrollArea h={`calc(100vh - ${rem(80)})`} mx="-md">
<Divider my="sm" />

<a href="#" className={classes.link}>
<a href="#" className={classes.link} onClick={e => e.preventDefault()}>
Home
</a>
<UnstyledButton className={classes.link} onClick={toggleLinks}>
Expand All @@ -184,10 +184,10 @@ export function HeaderMegaMenu() {
</Center>
</UnstyledButton>
<Collapse in={linksOpened}>{links}</Collapse>
<a href="#" className={classes.link}>
<a href="#" className={classes.link} onClick={e => e.preventDefault()}>
Learn
</a>
<a href="#" className={classes.link}>
<a href="#" className={classes.link} onClick={e => e.preventDefault()}>
Academy
</a>

Expand Down