chore: ensure macro is prepared for potential pretty printing improvements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I guess the change makes sense when the 'args' vector identifier doesn't have a space just before the colon. This is not currently the case, but it looks like it could change. The code has been merged. I'm excited because this is PageTop's first pull request. Thank you for the contribution! |
manuelcillero
added a commit
that referenced
this pull request
Dec 21, 2025
Reviewed-on: https://git.cillero.es/manuelcillero/pagetop/pulls/1 Co-authored-by: Manuel Cillero <[email protected]> Co-committed-by: Manuel Cillero <[email protected]>
manuelcillero
added a commit
that referenced
this pull request
Dec 21, 2025
Reviewed-on: https://git.cillero.es/manuelcillero/pagetop/pulls/1 Co-authored-by: Manuel Cillero <[email protected]> Co-committed-by: Manuel Cillero <[email protected]>
manuelcillero
added a commit
that referenced
this pull request
Dec 21, 2025
Reviewed-on: https://git.cillero.es/manuelcillero/pagetop/pulls/1 Co-authored-by: Manuel Cillero <[email protected]> Co-committed-by: Manuel Cillero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#117433 (comment)
I think this could be improved to split on
":"instead and totrimthe param to get rid of whitespace.I'm not 100% confident that would work exactly as intended though, therefore this PR makes the minimal change.