Refractor, ESLint, Fix CI/CD, make it readdy for PROD #25
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I am still getting issues with the npm install(buildx error) while doing a push to the docker |
|
Everythings looks fine to me
|
| @@ -28,8 +28,13 @@ jobs: | |||
| ${{ runner.os }}-node- | |||
| - name: Install Dependencies | |||
| run: npm install | |||
| - name: ESLint | |||
There was a problem hiding this comment.
Yeah works fine
Not big update here
| @@ -47,6 +52,8 @@ jobs: | |||
| username: ${{ github.repository_owner }} | |||
| password: ${{ secrets.GITHUB_TOKEN }} | |||
| registry: ghcr.io | |||
| - name: Set up QEMU | |||
There was a problem hiding this comment.
Just copy from OpenElis project , like they are using qemu before docker buildx
Worry about why it is failing 🥲
| build | ||
| vercel.json | ||
| tsconfig.json | ||
| package.json | ||
| package-lock.json | ||
| Dockerfile | ||
| compose.yaml |
| RUN rm -rf node_modules package-lock.json | ||
|
|
||
| # Install dependencies using npm ci for faster, consistent installs | ||
| RUN npm install | ||
|
|
||
| # Add node_modules/.bin to PATH for easier access to executables | ||
| # Add node_modules/.bin to PATH for easier access to executables |
There was a problem hiding this comment.
Got it from internet (railway forum)
Didn't work for me on CI
| "pre-commit": "lint-staged", | ||
| "prepare": "husky install" |
There was a problem hiding this comment.
when you run -> npx husky-init then they created this file with .husky(inside we have pre-commit file which uses npm run pre-commi)
| }, | ||
| "lint-staged": { | ||
| "src/**/*.{js,jsx,ts,tsx,json}": [ | ||
| "eslint --fix" | ||
| ], | ||
| "src/**/*.{js,jsx,ts,tsx,json,css,scss,md}": [ | ||
| "prettier --write" | ||
| ] | ||
| }, | ||
| "husky": { | ||
| "hooks": { | ||
| "pre-commit": "lint-staged" | ||
| } |
There was a problem hiding this comment.
From tutorial(vishwas- webpack)
| passport.use( | ||
| new TwitterStrategy( | ||
| { | ||
| consumerKey: process.env.TWITTER_OAUTH_API_KEY, | ||
| consumerSecret: process.env.TWITTER_OAUTH_SECRET, | ||
| callbackURL: `/auth/twitter/callback`, | ||
| // callbackURL: "/auth/twitter/callback" | ||
| }, | ||
| function (token, tokenSecret, profile, done) { | ||
| return done(null, profile); | ||
| } | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Not using this , anywhere at in future I will change it
| @@ -0,0 +1,382 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Got it from internet, it will help us in future
Good Note
Everythings looks fine to me