Review-update-Notification #331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Frankdevlopes
requested review from
DarinHajou,
Junman140,
adisa39,
fredrick-amoako,
joey364,
omotoshoayomikun,
rjen77,
soleil00,
swoocn,
vrajasekhar1,
yomarzz and
zolcsi
and removed request for
swoocn
Collaborator
vrajasekhar1
left a comment
vrajasekhar1
left a comment
There was a problem hiding this comment.
Review inputs provided for PR #330 are applicable for this one too.
One additional input: getUser is invoked twice in multiple functions. When data size grows, these calls need to be optimized to reduce DB load on large lists. This may be optional for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the updatereviewfeedback function including the notification sending logic to the recipient.