Skip to content
This repository was archived by the owner on Oct 30, 2021. It is now read-only.
This repository was archived by the owner on Oct 30, 2021. It is now read-only.

Don't publish binaries for git tags #129

Description

@mattficke

Pushing a commit with [publish binary] along with a tag referencing that commit leads to build failures, since Travis will run duplicate build jobs that both try to publish their binaries to the same place. Whichever one finishes first will succeed, the other will fail. This causes many commits to be incorrectly flagged as failing CI, though it doesn't cause really any substantive problems beyond that.

This issue was reported in mapbox/node-cpp-skel#108, and seems to have been fixed with mapbox/node-cpp-skel#139, so I think the next steps are:

  • add the node-cpp-skel updates to carmen-cache/scripts/publish.sh
  • make sure it works
  • merge

cc @springmeyer @apendleton

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions