This repository was archived by the owner on Oct 30, 2021. It is now read-only.
Conversation
vng
force-pushed
the
lru-cache
branch
4 times, most recently
from
February 23, 2019 00:11
47630d5 to
4e50a07
Compare
vng
force-pushed
the
lru-cache
branch
4 times, most recently
from
February 23, 2019 01:20
9ed1df4 to
1a5d4fd
Compare
Author
|
UPD. After benchmarks turned out that introduced LRU-cache doesn't give any performance. Looks like RockDBCache already have something like this inside. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that we have multiple equal calls to RocksCacheDB::__getmatching during one search request.
Benchmarks table like this https://github.com/mapbox/geocoding/issues/608 are coming soon.
Should be a good alternative until #134 will be done.