Exception handler for Telemetry SDK #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alfwatt
commented
Apr 5, 2019
alfwatt
commented
- Stubs documentation comments for the existing Public API
- Marks some Events constructors as to be deprecated, pending replacements
- Cleanup of MMETestHost
- Update name headers, remove empty class
rclee
reviewed
Apr 5, 2019
MapboxMobileEvents.xcodeproj/xcshareddata/xcschemes/MMETestHost.xcscheme
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 83.36% 84.02% +0.65%
==========================================
Files 73 75 +2
Lines 4010 4238 +228
==========================================
+ Hits 3343 3561 +218
- Misses 667 677 +10 |
alfwatt
force-pushed
the
aw-issue-mt-287
branch
2 times, most recently
from
e2b1690 to
6bfc851
Compare
rclee
reviewed
May 10, 2019
- Better imports in the .h, better import order in the .m - Group the deprecated event constructors, document the rest - Add scripts to project - MapboxMobileMetrics -> MapboxMobileEvents - Add MMEErrorDomain and associated values to MMEConstants - MMEEvent marks a number of deprecated methods for later warning flags - MMEEvent routes all event construction through to the designated initializer which now reports errors - MMEEventsManager adds Error & Exception Reporting - Some tests now fail because MMEEvent is immutable, will update - Move deviceOrientation and contentSizeScale into UIKit+MMEMobileEvents - Add dateWithDate: to MMEDate - Event equality uses the storage properties for efficiency, does not separately consider name - Fix some of the broken tests - Don't break encapsulation in MMEvent or MMEDate - Add MMEDateFakes to allow for sloppy matching of dates in tests - Group Categories in a Folder - Fix Static Analyzer warnings in APIClient - Add MME_DEPRECATED_GOTO - Xcode 10.2 updates and English -> en conversion - Add MMECrashTests.mm for basic crash event testing - Add `+ commentEventData` to MMECommonEventData - Fix tests which were broken on device - Turn on code coverage for testing in the Xcode project - Add NS_ASSUME_NONNULL blocks on MMEEvent, update tests to reflect - Fix nested test cases for encode decide of dates and events - Implement all the @Try{} blocks for the MMEventsManager Exception Free API
julianrex
reviewed
May 21, 2019
|
@alfwatt just added some comments I had pending; I see there have been some changes since I first wrote those, so apologies if any are out of date 😢 |
|
@julianrex that's a huge help, working through these issue now |
added 4 commits
May 23, 2019 17:07
Tests use the private constructor `initShared`
1ec5
reviewed
May 30, 2019
| @@ -53,3 +83,8 @@ brew install carthage | |||
| cd $PROJECT_DIR | |||
| carthage bootstrap | |||
| ``` | |||
|
|
|||
| <style> | |||
There was a problem hiding this comment.
GitHub-flavored Markdown doesn’t support <style> tags, so it just shows up as gibberish at the bottom.
There was a problem hiding this comment.
Renders as display:none for me
Co-Authored-By: Minh Nguyễn <[email protected]>
Co-Authored-By: Minh Nguyễn <[email protected]>
Co-Authored-By: Minh Nguyễn <[email protected]>
Co-Authored-By: Minh Nguyễn <[email protected]>
…initialized yet. Add test to expose the crasher and validate that the forced singleton constructor is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.