Skip to content

Commit

Permalink
Switch to Node v20 (internal-1654)
Browse files Browse the repository at this point in the history
  • Loading branch information
stepankuzmin authored and underoot committed Jul 31, 2024
1 parent 4fb7e8c commit 7d11804
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ workflows:

linux-defaults: &linux-defaults
docker:
- image: cimg/node:18.20-browsers
- image: cimg/node:20.15-browsers
working_directory: ~/mapbox-gl-js

mac-defaults: &mac-defaults
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- if: matrix.language == 'javascript-typescript'
name: Setup Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 20.x

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.20.2
20.15.1
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ Install the Xcode Command Line Tools Package
xcode-select --install
```

Install [node.js](https://nodejs.org/) version 18
Install [node.js](https://nodejs.org/) version 20
```bash
brew install node@18
brew install node@20
```

Clone the repository
Expand All @@ -26,10 +26,10 @@ npm install

### Linux

Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) version 18, [GNU Make](http://www.gnu.org/software/make/), and libglew-dev
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) version 20, [GNU Make](http://www.gnu.org/software/make/), and libglew-dev
```bash
sudo apt-get update
curl -sL https://deb.nodesource.com/setup_18.x | sudo bash -
curl -sL https://deb.nodesource.com/setup_20.x | sudo bash -
sudo apt-get install build-essential git nodejs libglew-dev libxi-dev
```

Expand All @@ -45,7 +45,7 @@ npm install

### Windows

Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) version 18, [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules).
Install [git](https://git-scm.com/), [node.js](https://nodejs.org/) version 20, [npm and node-gyp](https://github.com/Microsoft/nodejs-guidelines/blob/master/windows-environment.md#compiling-native-addon-modules).

Clone the repository
```bash
Expand Down
2 changes: 1 addition & 1 deletion buildspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 0.2
phases:
install:
runtime-versions:
nodejs: 18
nodejs: 20
commands:
- echo "//registry.npmjs.org/:_authToken=$NPMAccessToken" > ~/.npmrc
- npm whoami
Expand Down

0 comments on commit 7d11804

Please sign in to comment.