[MAPS3D-1072] update tiled_3d_model_bucket state after elevation upda…

…te (internal-869)
mapbox · Nov 7, 2023 · 8e6396d · 8e6396d
1 parent 0ce7259
commit 8e6396d
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/3d-style/data/bucket/tiled_3d_model_bucket.js b/3d-style/data/bucket/tiled_3d_model_bucket.js
@@ -231,11 +231,12 @@ class Tiled3dModelBucket implements Bucket {
     }
 
     elevationUpdate(terrain: Terrain, exaggeration: number, coord: OverscaledTileID, source: string) {
-
+        assert(terrain);
         const demTile = terrain.findDEMTileFor(coord);
-        if (demTile === this.terrainTile && exaggeration === this.terrainExaggeration) return;
+        if (!demTile) return;
+        if (demTile.tileID.canonical === this.terrainTile && exaggeration === this.terrainExaggeration) return;
 
-        if (terrain && demTile && demTile.dem && demTile.tileID.overscaledZ !== this.elevationReadFromZ) {
+        if (demTile.dem && demTile.tileID.overscaledZ !== this.elevationReadFromZ) {
             this.elevationReadFromZ = demTile.tileID.overscaledZ;
             const dem = DEMSampler.create(terrain, coord, demTile);
             if (!dem) return;
@@ -255,6 +256,8 @@ class Tiled3dModelBucket implements Bucket {
                 node.elevation = elevation;
             }
         }
+        this.terrainTile = demTile.tileID.canonical;
+        this.terrainExaggeration = exaggeration;
     }
 
     updateDEM(terrain: Terrain, dem: DEMSampler, coord: OverscaledTileID, source: string) {