Skip to content

Smarter warnings #39

Description

@springmeyer

context

The -isystem flag can be used to avoid seeing warnings from certain paths. It is useful for selectively avoiding warning noise for dependencies while continuing to keep warnings active for the code we are developing.

problem

The normal way of adding include paths with gyp is include_dirs. This adds paths using -I not -i system. So we need to add them a different way

solution

We can add paths with -isystem <(module_root_dir)/PATH HERE. For linux we'll add them into cflags. For OS X we'll add them into OTHER_CPLUSPLUSFLAGS since gyp is not consistent here for raw compiler flags

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions