Skip to content

Fresh clone + make raises an error #27

Description

@MattFerraro

On mac high sierra, on a fresh git clone with

~/Documents/git/vtvalidate$ node --version
v11.5.0

the make command crashes with:

../src/vtvalidate.cpp:177:48: error: 'ToObject' is deprecated: Use maybe version [-Werror,-Wdeprecated-declarations]
    v8::Local<v8::Object> buffer = buffer_val->ToObject();
                                               ^
/Users/matthew/.node-gyp/11.5.0/include/node/v8.h:2549:10: note: 'ToObject' has been explicitly marked deprecated here
  inline V8_DEPRECATED("Use maybe version", Local<Object> ToObject() const);
         ^
/Users/matthew/.node-gyp/11.5.0/include/node/v8config.h:326:29: note: expanded from macro 'V8_DEPRECATED'
  declarator __attribute__((deprecated(message)))

Expected behavior is that running make doesn't crash. Can others repro?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions