Skip to content

QUAL: fix Phan/PHPStan notices in massactions and customreports#43

Merged
mapiolca merged 2 commits into2026-03-25-add-mass-actions-for-external-module-tasksfrom
2026-03-26-add-phpstan-results-to-pr
Mar 26, 2026
Merged

QUAL: fix Phan/PHPStan notices in massactions and customreports#43
mapiolca merged 2 commits into2026-03-25-add-mass-actions-for-external-module-tasksfrom
2026-03-26-add-phpstan-results-to-pr

Conversation

@mapiolca
Copy link
Copy Markdown
Owner

Motivation

  • Corriger des alertes d'analyse statique (Phan et PHPStan) remontées comme GitHub notices sans changer le comportement à l'exécution.

Description

  • Ajouter @phan-var-force ?Task $taskstatic dans htdocs/core/tpl/massactions_pre.tpl.php et supprimer les isset() redondants autour de $search_xaxis et $search_groupby dans htdocs/core/customreports.php afin de rendre explicite l'initialisation pour les analyseurs statiques.

Testing

  • Vérification de syntaxe PHP exécutée avec php -l htdocs/core/tpl/massactions_pre.tpl.php et php -l htdocs/core/customreports.php, les deux commandes ont réussi (aucune erreur).

Codex Task

@mapiolca mapiolca merged commit a584d34 into 2026-03-25-add-mass-actions-for-external-module-tasks Mar 26, 2026
9 checks passed
@mapiolca mapiolca deleted the 2026-03-26-add-phpstan-results-to-pr branch March 26, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant