Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
entitycolumn.Description
admin/about.phpthat renders module information and is wired into the admin tabs vialib/dynamicsprices.lib.php.core/modules/modDynamicsPrices.class.phpto includeentityintabsql,tabfieldvalueandtabfieldinsertforc_commercial_category.admin/setup.phpand removed the oldensureCommercialCategoryColumns()helper and its call frommodDynamicsPrices::init().Product::TYPE_PRODUCTandProduct::TYPE_SERVICE(replacing single-type checks within_array(..., array(Product::TYPE_PRODUCT, Product::TYPE_SERVICE), true)) so services are included in update paths, and updated product selection SQL to usep.fk_product_type IN (0,1).entitycolumn toc_commercial_categorycreate statements and todolibarr_allversions.sqlinsert statements so new rows include anentityvalue.langs/*/dynamicsprices.langfiles to addLMDB_About*entries and clarify theCode_commercial_categorylabel.Testing
php -land they passed without errors.sql/dolibarr_allversions.sqlandsql/llx_c_commercial_category.sql) into a test database usingmysqland the schema changes applied successfully.Abouttab appears and the settings page loads (automated smoke check via HTTP request assertions succeeded).Codex Task