Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fk_user_sealetdate_sealexistent, afin d’améliorer l’audit et la lisibilité administrative.skill-creatorniskill-installer).Description
sealedOnet affichage du libellé « scellée le … » dans la cellule de statut du PDF via la fonctiontw_pdf_compose_status_celldanslib/timesheetweek_pdf.lib.php.tw_collect_summary_data(danslib/timesheetweek_pdf.lib.php) pour détecter la présence defk_user_seal/date_seal, étendre la requête SQL et remplir les champssealed_byetsealed_onquand disponibles.scellerdetimesheetweek_list.phpen détectant une seule fois la présence des colonnes et en exécutant unUPDATEcomplémentaire sans bloquer le scellement si la mise à jour échoue (log en warning).TimesheetWeek::seal()dansclass/timesheetweek.class.phppour détecter dynamiquement les colonnes optionnelles et écrirefk_user_seal/date_seallors du scellement, en mettant aussi à jour les propriétés de l’objet.sql/llx_timesheet_week.sqlet du script d’évolutionsql/update_all.sqlpour ajouterfk_user_seal,date_sealet leurs index si manquants.TimesheetWeekSummaryStatusSealedOn) dans les fichierslangs/*/timesheetweek.lang, incrémentation de la version du module à1.7.5danscore/modules/modTimesheetWeek.class.phpet mise à jour deChangeLog.mdetREADME.md.Testing
Codex Task