Added Version and Travis Badges; Issue #46 #47
Conversation
…interval as a parameter.
"check_if_model_trained_in_last_24hours()" now uses datetime.timedelta class.
|
Can you create a clean pull request without so many unrelated commits? Follow the steps here when you are working on a new feature: #9 (comment) |
README.md
Outdated
| @@ -19,3 +19,17 @@ python3 -m unittest tests | |||
| # Run a specific test | |||
| python3 -m unittest tests/test_basic | |||
| ``` | |||
|
|
|||
| Badges: | |||
There was a problem hiding this comment.
Can you put the badges at the top of the page? Right after the title # crashsimilarity.
README.md
Outdated
| Badges: | ||
| ```sh | ||
| # Version Badge | ||
| .. image:: https://badge.fury.io/gh/marco-c%2Fcrashsimilarity.svg |
There was a problem hiding this comment.
What is this doing? The badges should be added as images
There was a problem hiding this comment.
README.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # crashsimilarity | |||
|
|
|||
| [](https://badge.fury.io/gh/marco-c%2Fcrashsimilarity) | |||
|
|
|||
There was a problem hiding this comment.
Can you remove this blank line? This way the badges will be on the same line in the resulting output: https://github.com/aditya-iitd/crashsimilarity/blob/5699c976cfde783d1db68e3dcdfea81c13d0c5ef/README.md.
Actually, let's remove the version badge for now. We will add it in the future if we decide to publish this package on PyPI.
Codecov badge will be added once @ibrahimsharaf integrates codecov coverage.