Merge pull request #11 from marcolink/fix/max-depth

fix: maxDepth was not respected fully
marcolink · Sep 3, 2024 · 949ebfe · 949ebfe
2 parents 9bf5234 + 196c157
commit 949ebfe
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 12 deletions.
diff --git a/src/index.spec.ts b/src/index.spec.ts
@@ -677,19 +677,34 @@ describe('a generate json patch function', () => {
       },
     };
 
-    const patch = generateJSONPatch(before, after, { maxDepth: 3 });
-    expect(patch).to.eql([
-      {
-        op: 'replace',
-        path: '/firstLevel/secondLevel',
-        value: {
-          thirdLevel: {
+    it('detects changes as a given depth of 3', () => {
+      const patch = generateJSONPatch(before, after, { maxDepth: 3 });
+      expect(patch).to.eql([
+        {
+          op: 'replace',
+          path: '/firstLevel/secondLevel',
+          value: {
+            thirdLevel: {
+              fourthLevel: 'hello-brave-new-world',
+            },
+            thirdLevelTwo: 'hello',
+          },
+        },
+      ]);
+    });
+
+    it('detects changes as a given depth of 4', () => {
+      const patch = generateJSONPatch(before, after, { maxDepth: 4 });
+      expect(patch).to.eql([
+        {
+          op: 'replace',
+          path: '/firstLevel/secondLevel/thirdLevel',
+          value: {
             fourthLevel: 'hello-brave-new-world',
           },
-          thirdLevelTwo: 'hello',
         },
-      },
-    ]);
+      ]);
+    });
   });
 });
 

diff --git a/src/index.ts b/src/index.ts
@@ -186,8 +186,8 @@ export function generateJSONPatch(
         compareArrays(leftValue, rightValue, newPath);
       } else if (isJsonObject(rightValue)) {
         if (isJsonObject(leftValue)) {
-          if (maxDepth <= path.split('/').length) {
-            patch.push({ op: 'replace', path: path, value: rightJsonValue });
+          if (maxDepth <= newPath.split('/').length) {
+            patch.push({ op: 'replace', path: newPath, value: rightValue });
           } else {
             compareObjects(newPath, leftValue, rightValue);
           }