Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using HTML dialog element for image view #1227

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Using HTML dialog element for image view #1227

merged 2 commits into from
Feb 3, 2025

Conversation

marekdedic
Copy link
Owner

@marekdedic marekdedic commented Feb 3, 2025

Closes #1207

Copy link

relativeci bot commented Feb 3, 2025

imagelightbox-jquery

#335 Bundle Size — 12.22KiB (+0.13%).

b867656(current) vs e9d9903 master#324(baseline)

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#335
     Baseline
#324
Regression  Initial JS 12.22KiB(+0.13%) 12.21KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 27 27
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#335
     Baseline
#324
Regression  JS 12.22KiB (+100%) undefined

Bundle analysis reportBranch html-dialogProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

relativeci bot commented Feb 3, 2025

imagelightbox-native

#959 Bundle Size — 11.5KiB (+0.14%).

b867656(current) vs e9d9903 master#948(baseline)

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#959
     Baseline
#948
Regression  Initial JS 11.5KiB(+0.14%) 11.49KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 26 26
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#959
     Baseline
#948
Regression  JS 11.5KiB (+100%) undefined

Bundle analysis reportBranch html-dialogProject dashboard


Generated by RelativeCIDocumentationReport issue

@marekdedic marekdedic marked this pull request as ready for review February 3, 2025 15:22
@marekdedic marekdedic merged commit 97d145b into master Feb 3, 2025
14 of 15 checks passed
@marekdedic marekdedic deleted the html-dialog branch February 3, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus trap
1 participant