Mariadb4.x galera ps API v2 #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janlindstrom
approved these changes
Jun 22, 2021
Contributor
janlindstrom
left a comment
janlindstrom
left a comment
There was a problem hiding this comment.
In my opinion this looks good. I had only a very minor comments so you can if so choose ignore them and please send this to review for Teemu Ollakka.
src/wsrep_provider_v26.cpp
Outdated
| wsrep::ps_service* ps_service) | ||
| { | ||
| assert(ps_service); | ||
| if (not wsrep::ps_service_v1_probe(dlh)) |
Contributor
There was a problem hiding this comment.
I have not seen this before, does this compile in our old compilers?
src/wsrep_provider_v26.cpp
Outdated
|
|
||
| static void deinit_ps_service(void* dlh) | ||
| { | ||
| // assert(not wsrep::ps_service_v1_probe(dlh)); |
Contributor
There was a problem hiding this comment.
Please remove commented code lines, why this would not hold here?
src/ps_service_v1.cpp
Outdated
| int wsrep::ps_service_v1_init(void* dlh, | ||
| wsrep::ps_service* ps_service) | ||
| { | ||
| if (not (dlh && ps_service)) return EINVAL; |
Contributor
There was a problem hiding this comment.
Why not instead of ! ?
This commit adds support for Performanche Schema tables for Galera using the new Pefrormance Schema (ps) service.
sysprg
force-pushed
the
mariadb4.x-galera-ps-v2
branch
from
2ae0399 to
1f2a908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype of a new implementation of the interface to support performance schema tables in MariaDB, which does not require changes to the wsrep-API as it uses the wsrep service architecture, similar to the service for TLS.