Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DSTSUP-102): Set dimensions of checkmark #4416

Merged
merged 3 commits into from
Feb 10, 2025
Merged

fix(DSTSUP-102): Set dimensions of checkmark #4416

merged 3 commits into from
Feb 10, 2025

Conversation

sebald
Copy link
Member

@sebald sebald commented Feb 7, 2025

Description

Safari needs dimensions for SVGs!

What should be tested?

  • Open Safari, check if you see the checkmark when a Checkbox is checked.

Reviewers:

@marigold-ui/developer
@marigold-ui/designer

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:35am
marigold-storybook 🛑 Canceled (Inspect) Feb 7, 2025 9:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 9:35am

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: b27e982

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/components Patch
@marigold/storybook-config Patch
@marigold/docs Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/theme-docs Patch
@marigold/system Patch
@marigold/icons Patch
@marigold/theme-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Feb 7, 2025
@sebald sebald changed the title fix(checkbox): Set dimensions of checkmark fix(DSTSUP-102): Set dimensions of checkmark Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.46% (+0.05% 🔼)
8637/8684
🟢 Branches
89.86% (-0.06% 🔻)
452/503
🟢 Functions 98.68% 149/151
🟢 Lines
99.46% (+0.05% 🔼)
8637/8684
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Input.tsx
98.72% (-1.28% 🔻)
80% (-20% 🔻)
100%
98.72% (-1.28% 🔻)
🟢
... / Text.tsx
100%
45.45% (-9.09% 🔻)
100% 100%
🟢 system/src/utils.ts 100%
69.23% (-25.21% 🔻)
100% 100%

Test suite run success

613 tests passing in 80 suites.

Report generated by 🧪jest coverage report action from b27e982

@aromko aromko merged commit 7f0841d into main Feb 10, 2025
15 checks passed
@aromko aromko deleted the DSTSUP-102 branch February 10, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants