Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refa([DST-665]): Refa Accordion #4421

Merged
merged 11 commits into from
Feb 14, 2025
Merged

refa([DST-665]): Refa Accordion #4421

merged 11 commits into from
Feb 14, 2025

Conversation

jim761
Copy link
Contributor

@jim761 jim761 commented Feb 12, 2025

Description

Breaking Change: Added two Accordion components Accordion.Header and Accordion.Content.
Accordion.Header replaces the title in Accordion.Item.
Accordion.Content is now the place where the content for the panel needs to be.

Changed the Accordion Documentation Page.
Updated the Accordion in Storybook.

Reviewers:

Which persons should review this PR? Add person with @mentions

Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 49c3400

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@marigold/docs Major
@marigold/components Major
@marigold/system Major
@marigold/theme-b2b Major
@marigold/theme-core Major
@marigold/storybook-config Patch
@marigold/theme-docs Patch
@marigold/theme-rui Patch
@marigold/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 17 resolved Feb 14, 2025 8:04am
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 8:04am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 8:04am

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
99.34% (-0.08% 🔻)
8541/8598
🟢 Branches
90% (-1.15% 🔻)
441/490
🟢 Functions
98.68% (+0.03% 🔼)
149/151
🟢 Lines
99.34% (-0.08% 🔻)
8541/8598
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / AccordionContext.tsx
83.33% 50% 100% 83.33%
🟢
... / AccordionHeading.tsx
100% 100% 100% 100%
🟢
... / AccordionPanel.tsx
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / HelpText.tsx
97.83% (-2.17% 🔻)
76.92% (-23.08% 🔻)
100%
97.83% (-2.17% 🔻)
🟢
... / Input.tsx
98.72% (-1.28% 🔻)
80% (-20% 🔻)
100%
98.72% (-1.28% 🔻)

Test suite run success

597 tests passing in 78 suites.

Report generated by 🧪jest coverage report action from 49c3400

@sebald
Copy link
Member

sebald commented Feb 12, 2025

Needs a changeset (see bot above) that marks this PR as a breaking change and major version change

Copy link
Contributor Author

@jim761 jim761 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missclick

aromko
aromko previously approved these changes Feb 13, 2025
aromko
aromko previously approved these changes Feb 14, 2025
@aromko aromko enabled auto-merge (squash) February 14, 2025 07:16
sebald
sebald previously approved these changes Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants