-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[DST-676]: add button styles to rui theme #4443
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
4094479
to
38c6329
Compare
Description
Button styles added in 4 variants according to OriginUI:
Also added states:
disabled
hover
pending (for loading)
focus-visible (with outline when tabbed into)
[] This change requires a UI-Kit update - inform Alex Tirado (@tirado-rx , @benjirsvx )
What should be tested?
Look into Storybook "Button".
The basic show all variants add once. Toggle disable to true.
Also look add loading story.
In general color should be checked.
For hover I used our accent color in secondary and ghost variant like OriginUI - I think this should be changed but idk which color to use.
Reviewers:
@marigold-ui/developer
@marigold-ui/designer