Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[DST-676]: add button styles to rui theme #4443

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

aromko
Copy link
Contributor

@aromko aromko commented Feb 17, 2025

Description

Button styles added in 4 variants according to OriginUI:

  • primary
  • secondary (default when no variant specified)
  • destructive
  • ghost

Also added states:

  • disabled

  • hover

  • pending (for loading)

  • focus-visible (with outline when tabbed into)

  • [] This change requires a UI-Kit update - inform Alex Tirado (@tirado-rx , @benjirsvx )

What should be tested?

Look into Storybook "Button".

The basic show all variants add once. Toggle disable to true.

Also look add loading story.

In general color should be checked.

For hover I used our accent color in secondary and ghost variant like OriginUI - I think this should be changed but idk which color to use.

Reviewers:

@marigold-ui/developer
@marigold-ui/designer

Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: 4fed046

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marigold-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 6:05pm
marigold-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 6:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marigold-production ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 6:05pm

@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Feb 17, 2025
@aromko aromko merged commit 0d2c6cc into rui-theme-1.0 Feb 18, 2025
8 checks passed
@aromko aromko deleted the DST-676_rui-button-styles branch February 18, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants