Skip to content

Get raw transactions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markferry wants to merge 2 commits into
base: pylint-and-pip-fixes
Choose a base branch
from
+31 −16
Open

Get raw transactions #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53ce280
Refactor _get_transactions to _get_widget_transactions
markferry Sep 18, 2021
746c3bd
feat: get_raw_transactions
markferry Sep 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions moneydashboard/moneydashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,23 @@ def _get_accounts(self):
accounts[account["Id"]] = account
return accounts

def _get_transactions(self, type: int):
"""Retrieve transactions from MoneyDashboard account"""
def _get_transactions(self, url, headers):
try:
response = self._get_session().request("GET", url, headers=headers)
response.raise_for_status()
except HTTPError as http_err:
self.__logger.error(
"[HTTP Error]: GET failed (%s) for url: %s", http_err, url
)
raise GetTransactionListFailedException from http_err
except Exception as err:
self.__logger.error("[Error]: GET failed (%s) for url: %s", err, url)
raise GetTransactionListFailedException from err
else:
return response.json()

def _get_widget_transactions(self, type: int):
"""Retrieve transactions from MoneyDashboard widget"""
if type not in self._transactionFilterTypes:
self.__logger.error("Invalid Transaction Filter.")
raise InvalidTransactionListTypeFilter
Expand All @@ -177,19 +192,19 @@ def _get_transactions(self, type: int):
)

headers = self._get_headers()
try:
response = self._get_session().request("GET", url, headers=headers)
response.raise_for_status()
except HTTPError as http_err:
self.__logger.error(
"[HTTP Error]: Failed to get Transaction List (%s)", http_err
)
raise GetTransactionListFailedException from http_err
except Exception as err:
self.__logger.error("[Error]: Failed to get Transaction List (%s)", err)
raise GetTransactionListFailedException from err
else:
return response.json()
return self._get_transactions(url, headers)

def get_raw_transactions(self, count: int = 65535):
"""Retrieve `count` transactions in MoneyDashboard json format"""
self.__logger.info("Getting Raw Transactions...")
self._login()

url = (
f"https://my.moneydashboard.com/transaction/GetTransactions?limitTo={count}"
)

headers = self._get_headers()
return self._get_transactions(url, headers)

def _money_fmt(self, balance):
return (
Expand Down Expand Up @@ -281,7 +296,7 @@ def get_balances(self):
return json.dumps(balance)

def get_transactions(self, type):
transactions = self._get_transactions(type)
transactions = self._get_widget_transactions(type)

transaction_list = []
for transaction in transactions:
Expand Down