MLE-12345 I will not rest until Black Duck is happy. #1802
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids warnings on Spring 5.x.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Spring 5.x security vulnerabilities by modifying dependency exclusion strategies in the ml-development-tools build configuration. The change improves security posture by preventing transitive dependencies that could introduce vulnerabilities.
- Updates dependency exclusion approach for marklogic-junit5 library
- Enhances comment documentation to explain the security rationale
| testImplementation ("com.marklogic:marklogic-junit5:1.5.0") { | ||
| exclude module: "marklogic-client-api" | ||
| transitive = false |
There was a problem hiding this comment.
Setting transitive = false excludes ALL transitive dependencies, which is more aggressive than the previous approach that only excluded marklogic-client-api. This could potentially break functionality if other required dependencies from marklogic-junit5 are needed. Consider using exclude group: to specifically target Spring dependencies instead.
Suggested change
| transitive = false | |
| exclude group: 'org.springframework' |
Copilot uses AI. Check for mistakes.
BillFarber
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids warnings on Spring 5.x