MLE-23230 Tweaking retry interceptor #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
requested review from
anu3990,
BillFarber and
stevebio
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR tweaks the retry interceptor to handle additional network error conditions by adding "Broken pipe" as a retryable exception message.
- Added "Broken pipe" as a retryable exception condition in the RetryInterceptor
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
68
to
+72
| e.getMessage().contains("Failed to connect") || | ||
| e.getMessage().contains("unexpected end of stream") || | ||
| e.getMessage().contains("Connection reset") || | ||
| e.getMessage().contains("Read timed out") | ||
| e.getMessage().contains("Read timed out") || | ||
| e.getMessage().contains("Broken pipe") |
There was a problem hiding this comment.
String-based exception detection is fragile and error-prone. Consider checking exception types (e.g., SocketException, ConnectException) or using more specific exception handling instead of relying on error message text matching.
Copilot uses AI. Check for mistakes.
BillFarber
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.