This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Fix for infinite recursion bug #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the script is loaded twice in Firefox, then axisLabels will be registered twice in the plugins array, which eventually causes an infinite recursion, since the trick with the secondPass flag fails in these circumstances.
|
This pull request can be automatically merged by project collaborators. |
|
Heya, sorry for taking so long to respond. I see what you're saying; however, I think it might be better to put this check into init() instead. I would also prefer setting the variable to false at the top of the file rather than checking if it's undefined. |
nmoinvaz
reviewed
Dec 7, 2017
jquery.flot.axislabels.js
Outdated
| @@ -454,8 +455,8 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | |||
| } | |||
|
|
|||
|
|
|||
| if(jqueryFlotAxisLabelsIsRegistered !== undefined){ | |||
| var jqueryFlotAxisLabelsIsRegistered = true; | |||
| if(jqueryFlotAxisLabelsIsRegistered !== false){ | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request regarding the following bug:
If, for whatever reason, jquery.flot.axislabels.js is loaded twice, the plugin gets registered twice in the $.plot.plugins array and therefore the hook function is registered twice, too. For this particular plugin, this leads to an infinite recursion, because somehow the trick with the secondPass flag fails and the second call to the hook function never returns, but again calls the draw function, which calls the hook function twice again, and the second call again never returns and so on.
A demonstration can be found here: https://gist.github.com/walkevin/cbb6454e521f30126c13 (Notice that you might need to change the source for the axislabels.js. I didn't find it on a CDN Service)
You might argue that it is the responsibility of the developer to assure that the script is loaded only once, but since the error is so catastrophic and has such an unexpected reason which is specific to this plugin, I'm suggesting a simple fix, just to make sure that the plugin is never registered twice.