Skip to content

Jung/staking#69

Open
prateekreddy wants to merge 158 commits intomasterfrom
jung/staking
Open

Jung/staking#69
prateekreddy wants to merge 158 commits intomasterfrom
jung/staking

Conversation

@prateekreddy
Copy link
Copy Markdown
Member

No description provided.

Comment thread contracts/staking/l2_contracts/JobManager.sol Outdated
Comment thread contracts/staking/l2_contracts/NativeStaking.sol Outdated
Comment thread contracts/staking/l2_contracts/NativeStaking.sol Outdated
Comment thread contracts/staking/l2_contracts/SymbioticStaking.sol Outdated
_verifyProof(_jobId, _proof);

uint256 feePaid = jobs[_jobId].feePaid;
uint256 pendingInflationReward = _updateInflationReward(jobs[_jobId].operator);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should probably be part of rewardManager or stakingManager.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[discuss]

if (operatorJobCompletionEpochs[_operator].length == 0) return 0;

// list of epochs in which operator has completed jobs
uint256[] storage completedEpochs = operatorJobCompletionEpochs[_operator];
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The array size for an operator will always be 1. Because in the next epoch, if there was some job completed then the distribution happens right? Is there a way apart from job completion when this is updated?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why it always becomes 0.

Current epoch number gets pushed into the array if the last element of the array isn't current epoch.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Comment thread contracts/staking/l2_contracts/RewardDistributor.sol Outdated
Comment thread contracts/staking/l2_contracts/RewardDistributor.sol Outdated
Comment thread contracts/staking/l2_contracts/RewardDistributor.sol Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants