fix: forward MarmotClient capabilities to KeyPackageManager#74
fix: forward MarmotClient capabilities to KeyPackageManager#74maddadder wants to merge 1 commit into
Conversation
The capabilities option on MarmotClient was stored on the instance but never passed to KeyPackageManager, so generateKeyPackage() always fell back to defaultCapabilities(). Custom capabilities (e.g. SelfRemove proposal 0x000A required by Amethyst for MDK interop) were silently ignored. Forward this.capabilities to KeyPackageManager and through to generateKeyPackage() in create() (which also covers rotate()).
🦋 Changeset detectedLatest commit: 855891b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit 855891b on May 27, 2026 3:17pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis PR enables client capabilities to be forwarded to key package generation. ChangesCapabilities forwarding to key package generation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The capabilities option on MarmotClient was stored on the instance but never passed to KeyPackageManager, so generateKeyPackage() always fell back to defaultCapabilities(). Custom capabilities (e.g. SelfRemove proposal 0x000A required by Amethyst for MDK interop) were silently ignored. Forward this.capabilities to KeyPackageManager and through to generateKeyPackage() in create() (which also covers rotate()).
See #73
Summary by CodeRabbit
Release Notes