Fix the type annotation for 'argmap' #989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ArgMap type alias defined the mapping option (for
Schema.from_dict
) to allowField
ortype[Field]
, but this isincorrect. The following construction does not work:
Correct by simply removing
type[Field]
from the alias.A quick included improvement is to make the handling of type narrowing
for
argmap
a little bit more uniform in style (we had it 3 differentways in different places), and to use a cast to replace a type ignore
with something a little easier to read.