-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for good index (and other markdown) rendering on GitLab and Codeberg #401
base: main
Are you sure you want to change the base?
Conversation
… of 'main' The DEFAULT_BRANCH environment variable can still be used to override it.
This change may need some revisiting, because it copies over code from the build-index.sh.
8fb1cf6
to
9aa0960
Compare
I think I've addressed my own concerns by 1. taking the pattern already established in wg-meta.sh (no need for a function call here, the variables are populated at sourcing time), and 2. applying this to get the old "GitHub" text as a hostlabel that is looked up based on the git host. The only remaining differences a
|
I think that this is now similarly mature as #399 was: It should not alter the output of GitHub workflows any more. |
# default-branch.py recognition only works on GitHub; on other hosters it needs | ||
# to be set manually (also around setup.mk!), or they just use the default | ||
# value. | ||
DEFAULT_BRANCH := main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEFAULT_BRANCH := main | |
DEFAULT_BRANCH ?= main |
Following up on #399
(which to my knowledge I can't indicate to GitHub in a way that it only shows the commits after "Support non-GitHub hosts for .note.xml generation")[edit: A force push of a fixed commit message after 399 was merged did resolve this], these are changes that'd make using Codeberg & co easier,but they'll probably need some rework after discussion.As before with #399, I'd like to leave this sit for some time until I request review (while still having it available for the curious).
Prominent points I'm not too happy with are:
The changed setup-readme.sh more or less copies over (and extends) the big per-host switch that is already in build-index.sh. I suppose having a script like wg-meta.sh would be the place to outsource this?[edit: Now doing something very similar to wg-meta.sh in host-meta.sh]Existing output is changed where GitHub is replaced with github.com. If 1. is properly resolved, there could be a host label that'd be used in its place.[edit: There is now a hostlabel variable generated for known hosters]