P2.1: unify industrial workstation UX, Lucide actions and fast search - #153
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 915628a4bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (text.Equals("Pause", StringComparison.OrdinalIgnoreCase) || | ||
| text.Equals("Resume", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| button.Visibility = Visibility.Collapsed; |
There was a problem hiding this comment.
Keep the Resume action available for interrupted FAT sessions
When an active FAT session is paused or loses its IED connection, IoTestSessionController enters Paused/Interrupted, keeps CanStart false, and explicitly requires Session.Resume() after reconnection to establish a new baseline. Collapsing the only Resume button makes that transition unreachable—the primary workflow button remains disabled while the session is active—so operators must stop the session instead of continuing its evidence journal. Keep Resume accessible or route another enabled action to Session.Resume() in these states.
Useful? React with 👍 / 👎.
Why
The P2 palette is calmer, but real workstation review showed that ARSAS still reads too much like an experimental desktop app: action affordances are inconsistent, key toolbars remain text-only, and large projects have no rapid IED/signal search.
P2.1 scope
This PR is visual/navigation-only. IEC 61850 engine behavior, multi-IED connection state, FAT scope, evidence capture and command semantics are unchanged.
Industrial workstation integration
Lucide action language
Search designed for hundreds of IEDs
Regression coverage
Adds source/resource contract tests locking the Lucide/search resource system, existing-collection filtering, FAT search placement, hidden Pause/Resume, large-IED search fields and P2→P2.1 overlay order.
Please gate merge on WPF/XAML compilation, full ARSAS regression tests, focused IO FAT validation, portable publish and portable smoke test.