Fix IEC 61850 millisecond timestamp rounding - #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer issue
Relay and ABB SAS can show an IEC 61850 event as
31.201while ARSAS showed31.200for the same source timestamp.Root cause
ARSAS formatted sub-millisecond
DateTime/DateTimeOffsetvalues directly with.fff. That exposes the millisecond component without first rounding the full timestamp. A source value such as31.2006000therefore rendered as31.200.Fix
.0005000) rounds forward31.2006 -> 31.201, midpoint behavior, second/minute carry, and raw evidence preservationScope
The patch intentionally does not change IEC 61850 acquisition, report timestamps at source, NTP/SNTP behavior, GOOSE capture clocks, or stored evidence precision. It corrects only millisecond-resolution presentation.
Validation
Final head
803179408d9052f7b53daeb14fcea292e9429c83passed:The earlier bot-generated report-alignment commit produced
action_requiredchecks with no jobs because GitHub does not recursively trigger normal PR workflows from the bot push. A final human-authored no-logic comment update retriggered CI on the exact final source above.