Show full-resolution IEC 61850 timestamp on FAT hover - #157
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdc1a601d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var relay = evidence.IedTimestamp?.ToString("O", CultureInfo.InvariantCulture) ?? "not supplied"; | ||
| var displayed = global::ArIED61850Tester.Iec61850TimestampPresentation.FormatMilliseconds( | ||
| evidence.IedTimestamp, | ||
| "yyyy-MM-dd HH:mm:ss.fff zzz", |
There was a problem hiding this comment.
For evidence with a nonzero UTC offset, the FAT grid shows OnRelayTimestampText/OffRelayTimestampText using yyyy-MM-dd HH:mm:ss.fff, but this tooltip adds zzz. Consequently, the line labeled “Displayed” is not the exact value visible in the grid (for example, it appends +07:00), undermining the intended audit comparison. Format this line through the same grid formatter or omit the offset.
Useful? React with 👍 / 👎.
Customer dispute UX
The FAT grid intentionally displays relay timestamps at millisecond resolution using nearest-ms rounding, e.g. a raw IEC 61850 value ending in
31.2006000is displayed as31.201.To make that behavior auditable during customer witness/dispute discussions, the existing ON/OFF relay-time hover tooltip now shows:
Oprecision;The underlying evidence value is unchanged. This is presentation/traceability only.
Regression coverage locks the customer case
31.2006000 -> displayed 31.201while preserving the raw full-resolution timestamp in the tooltip.