Skip to content

Clarify FAT timestamp hover as decoded precision evidence #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masarray wants to merge 2 commits into from
Closed

Clarify FAT timestamp hover as decoded precision evidence #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b475e4c
Label FAT hover timestamp as decoded evidence, not raw wire data
masarray Aug 13, 2026
529411a
Lock honest decoded-timestamp wording in FAT hover
masarray Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Models/IoTesting/IoTestModels.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ private static string BuildEvidenceToolTip(IoTestTransitionEvidence? evidence, s
var rawRelay = evidence.IedTimestamp?.ToString("O", CultureInfo.InvariantCulture) ?? "not supplied";
var captured = evidence.CapturedAt.ToString("O", CultureInfo.InvariantCulture);
return $"Displayed (rounded to nearest ms): {displayed}\n" +
$"Raw IED timestamp (full precision): {rawRelay}\n" +
$"Decoded IED timestamp (full precision): {rawRelay}\n" +
$"ARSAS capture (full precision): {captured}\n" +
$"Quality: {evidence.Quality}\nSource: {evidence.AcquisitionSource}\n" +
$"{evidence.Verdict}: {evidence.VerdictReason}";
Expand Down
5 changes: 3 additions & 2 deletions tests/ARSAS.Tests/IoFatTimestampTooltipTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace ARSAS.Tests;
public sealed class IoFatTimestampTooltipTests
{
[Fact]
public void TimestampHover_ShowsRoundedDisplayAndRawFullPrecision()
public void TimestampHover_ShowsRoundedDisplayAndDecodedFullPrecision()
{
var timestamp = new DateTimeOffset(2026, 8, 13, 12, 0, 31, TimeSpan.FromHours(7))
.AddTicks(2_006_000);
Expand All @@ -34,9 +34,10 @@ public void TimestampHover_ShowsRoundedDisplayAndRawFullPrecision()

Assert.Contains("Displayed (rounded to nearest ms): 2026-08-13 12:00:31.201 +07:00", tooltip, StringComparison.Ordinal);
Assert.Contains(
"Raw IED timestamp (full precision): " + timestamp.ToString("O", CultureInfo.InvariantCulture),
"Decoded IED timestamp (full precision): " + timestamp.ToString("O", CultureInfo.InvariantCulture),
tooltip,
StringComparison.Ordinal);
Assert.DoesNotContain("Raw IED timestamp", tooltip, StringComparison.Ordinal);
Assert.Contains("ARSAS capture (full precision):", tooltip, StringComparison.Ordinal);
Assert.Contains("Quality: Good", tooltip, StringComparison.Ordinal);
Assert.Contains("Source: BRCB", tooltip, StringComparison.Ordinal);
Expand Down
Loading