fix: show static DataSet GGIO members for Open SCL and discovery - #181
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Hardening added after the functional fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Signal Selection can omit static DataSet members, especially Siemens object-level FCD members such as GGIO status points. The live-discovery path already has engine-side mandatory DataSet inventory support, but the offline Open SCL mapper still filtered unresolved FCDs before they reached the selector.
The supplied Siemens CID pattern uses object-level FCDA entries (
daName=""), so members likeGGIO6.CBOpnd,GGIO6.CBClsd,GGIO2.TCS1Fail,GGIO2.ComFail,GGIO2.FWUpdated, andGGIO1.LocOpnCMDstamust remain visible even when a unique primary leaf is not yet resolved.Fix
SclWorkspaceSignalMapper, apply normal operational filtering first, then merge the mandatory DataSet inventory so unresolved object-level FCD members cannot be filtered out;Design constraint
This does not guess
.stValfrom FC=ST. If ARIEC cannot resolve a unique primary DataAttribute, ARSAS preserves the original DataSet member as an unresolvedDataSetrow. Engine type/VAA/SCL semantics remain authoritative.Expected result
Signal Selection should contain every static DataSet member for both paths:
workspace.DesignModel.device.LiveDiscoveryModel.No user selection is auto-enabled by this change.