Use premium semantic badges for IEC 61850 process values - #195
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generic Boolean/process state was visually mapped as
True/Closed/ON = redandFalse/Open/OFF = green. That makes a normal state look like alarm severity and trains users to read red as an error even when the point is simply asserted.Visual strategy
Process state is now intentionally independent from quality/severity:
The badge deliberately uses text + glyph shape + color, so color is not the only state cue. No per-cell drop shadows are used, preserving DataGrid virtualization performance.
Semantic hardening
A new presentation-only
Iec61850ValueStatePresentationclassifier is shared by live points and SOE entries. Bare numeric0/1is classified as inactive/active only when IEC discovery metadata proves the point is Boolean/SPS; analog values, counters and numeric set points such as0 Aor numeric1remain neutral. ExplicitTrue/Falseand DPCOpen [01] / Closed [10] / Intermediate [00] / Bad [11]remain unambiguous.SOE entries now preserve the point IEC data type from the runtime so Event Log presentation has the same type evidence as Live Monitor.
Scope
The reusable
ProcessValueBadgeTemplateis applied to:The Command Panel current-value badge also adopts blue/slate state colors. Control action button colors, Quality presentation, Diagnostics WARN/ERROR colors, and availability/success colors are intentionally unchanged.
Regression coverage
Tests lock:
0/1type-awareness;true is red / false is greenSOE language.Final branch contains only production source/model/runtime changes and regression tests; temporary patch tooling was removed before PR creation.