Skip to content

Fix Save SCL edition toggle clipping and dynamic RCB status - #197

Merged
masarray merged 4 commits into
mainfrom
fix/save-scl-edition-toggle-and-dynamic-rcb
Aug 16, 2026
Merged

Fix Save SCL edition toggle clipping and dynamic RCB status#197
masarray merged 4 commits into
mainfrom
fix/save-scl-edition-toggle-and-dynamic-rcb

Conversation

@masarray

Copy link
Copy Markdown
Owner

Field regressions

Two field screenshots exposed independent issues:

  1. The Save SCL Edition 1 / Edition 2 toggle still rendered its lower edge/focus chrome too tightly inside the selector shell even after the dialog footer clipping fix.
  2. A source-unbound URCB (A_URCB01) whose successful live DatSet read returned the runtime DataSet AR_HYB_01 was shown as Config mismatch. That is a valid dynamic-RCB binding pattern, not evidence that a fixed source binding disagrees with the IED.

Save SCL fix

  • Keep each edition toggle at 44 DIP, but grow the selector shell from 52 to 60 DIP.
  • Reserve 6 DIP vertical padding and center the toggles, leaving real internal safe area instead of the old exact 4 + 44 + 4 = 52 fit.
  • Disable the external WPF focus visual and retain the existing internal 2 px focused border as the keyboard focus cue.
  • Set the selector shell/grid/toggles ClipToBounds=false so DPI antialias/focus edges are not cut.

Dynamic RCB evidence fix

  • A successful live DatSet read with blank source binding + populated live binding is classified as a valid dynamic runtime binding and is not a source/live configuration conflict.
  • A source-unbound RCB remains Unknown/informational before live verification instead of being painted as an operational No DataSet failure.
  • A fixed source binding remains strict: live verified empty or a different live DataSet is still a real configuration mismatch.
  • Failed/unattempted live reads remain unresolved evidence and do not create either a mismatch or a dynamic-binding claim.

Regression coverage

  • Field-shaped dynamic binding using AA1C1F13R4Application/LLN0.AR_HYB_01.
  • Fixed-source vs empty/different live bindings remain conflicts.
  • Source-unbound pre-check state remains Unknown.
  • Save SCL selector geometry locks the 60 DIP shell, 6 DIP vertical safe area, centered 44 DIP toggles, internal focus visual, and non-clipping contract.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 12f12f7 into main Aug 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant