Skip to content

Fix Live Monitor search and unverified-report polling regression - #202

Merged
masarray merged 18 commits into
mainfrom
fix/live-monitor-regression-audit
Aug 17, 2026
Merged

Fix Live Monitor search and unverified-report polling regression#202
masarray merged 18 commits into
mainfrom
fix/live-monitor-regression-audit

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0 regression audit

Field retest found two regressions: the IEC Explorer Live Signal search surface disappeared, and real IED changes could appear frozen while Event Log received no new SOE.

Root causes

  1. The Explorer selected-IED grid no longer had any search/header row; it bound directly to SelectedDevice.Points with no presentation filter.
  2. MMS verification was incorrectly slowed as soon as report traffic existed, even when dchg/qchg/dupd delivery had not been proven. A fast status point could fall from the configured 1 s cadence to 5 s while an unverified report was still considered primary. Short relay pulses could therefore occur entirely between MMS verification reads and be missed if the report subscription was silently not delivering change events.

Fix

  • Restore a modern Live Signal search bar above the selected IED grid.
  • Search filters only ICollectionView for the current SelectedDevice.Points; the authoritative monitored collection is never mutated.
  • Search covers signal, IEC telegram/reference, displayed value, quality, acquisition, category and IEC data type.
  • Add modern Lucide search + clear affordance.
  • Reapply the search filter when the selected IED changes.
  • Introduce ReportVerificationPollingPolicy: assigned/initial report traffic alone never slows MMS fallback.
  • Until a real report change edge is verified, MMS stays at the configured polling cadence.
  • Only a verified report stream may move to low-rate MMS verification.

Safety impact

This restores the intended fail-safe hierarchy: report-first when proven, but no blind interval where an unverified RCB can suppress timely MMS fallback. Event Log/SOE semantics are unchanged; the fix improves the chance of observing discrete changes when report delivery is degraded.

Regression coverage

  • unassigned report -> configured MMS cadence;
  • armed but no traffic -> configured MMS cadence;
  • traffic seen but dchg unverified -> configured MMS cadence;
  • verified report -> low-rate verification allowed;
  • Explorer search surface and presentation-only filtering are locked by source regression tests.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 5bf6019 into main Aug 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant