P3: gate dynamic reports by ARIEC association capability - #213
Merged
Conversation
masarray
marked this pull request as ready for review
August 18, 2026 02:34
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P3 — Consume association capability before dynamic reporting
Pins ARSAS to ARIEC61850 PR #85 (
5149a28d7d8ab5a2126595a6ccaa130c46807dfe) and makes the engine's capability-aware planner authoritative at both decision points:ARSAS does not duplicate MMS/RCB capability logic. It passes current association evidence to ARIEC and consumes the returned acquisition plan.
Effective capability gate
ARIEC P3 evaluates negotiated MMS Write / DefineNamedVariableList / DeleteNamedVariableList service bits plus fresh per-RCB DatSet, RptEna, TrgOps, OptFlds, GI, IntgPd, ownership/reservation and DataSet evidence. Unknown negotiation evidence is not treated as unsupported; explicit unsupported service bits are honored.
Critical activation fix consumed here
The P3 engine preserves fresh probed RCB Attributes and restores them onto the selected ReportControlCandidate before activation. This prevents a dynamic RCB that exposed TrgOps during availability probing from later being rejected merely because that evidence was lost between planning and StartPersistentReportMonitorAsync.
Diagnostics and safety
Regression coverage ensures ARSAS uses the capability-aware planner twice (initial + revalidation), never calls the bare hybrid planner from this bridge, and pins the reviewed P3 engine/provenance.