P4: attempt dynamic reporting before final polling - #214
Merged
Conversation
masarray
marked this pull request as ready for review
August 18, 2026 03:11
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P4 — Dynamic attempt required before final polling
Pins ARSAS to ARIEC61850 PR #86 (
2a932e183931eb65c775fe01cf8a47bf8a9af458) and consumes the engine's P4 planning/runtime attempt evidence.Per-point planning evidence
MmsHybridDynamicAttemptEvidenceBuilderoutput into ARSASPlannedmeans runtime still owes an actual dynamic activation attemptSkippedcarries an explicit fallback reasonStatic failure -> dynamic recovery
An engine-authoritative static RCB is still preferred first. If its fresh RCB revalidation, capability revalidation, subscription readiness, or actual activation fails, ARSAS immediately re-runs the same authoritative signals with static BRCB/URCB disabled. A capability-qualified dynamic BRCB/URCB is then attempted before polling may become final.
Runtime dynamic attempt / cleanup
Direct dynamic plans and static-recovery dynamic plans call ARIEC
StartPersistentReportMonitorWithAttemptEvidenceAsync. ARSAS records whether a real dynamic write/configuration attempt occurred, the structured failure reason, and best-effort cleanup result. Failed mutated attempts therefore do not silently leave temporary DataSet/RCB state behind.Physical validation telemetry
Validation snapshots now retain:
MMS reads still provide initial snapshot and verification safety; P4 changes when a point may be classified as the steady-state final polling fallback.