stream transfer history #4861
stream transfer history #4861
Conversation
modship
changed the base branch from
feature/execution-info-grpc-1
to
main_2_6
| execution-trace = ["massa_execution_exports/execution-trace"] | ||
| execution-trace = [ | ||
| "massa_execution_exports/execution-trace", | ||
| "schnellru" |
| @@ -91,7 +96,7 @@ massa_event_cache = { workspace = true } | |||
| tempfile = { workspace = true, optional = true } | |||
| massa_wallet = { workspace = true } | |||
| massa-proto-rs = { workspace = true } | |||
| schnellru = { workspace = true } | |||
| schnellru = { workspace = true, optional = true } | |||
There was a problem hiding this comment.
Removing "optional = true" here add a warning when compiling without any feature:
warning: extern crate `schnellru` is unused in crate `massa_execution_worker`
| @@ -75,6 +77,9 @@ pub mod test_exports; | |||
| /// types for execution-trace / execution-info | |||
| pub mod types_trace_info; | |||
|
|
|||
| /// types for execution-info | |||
| pub mod execution_info; | |||
There was a problem hiding this comment.
is there a reason to separate types_trace_info and execution_info here?
| @@ -11,6 +11,7 @@ documentation = "https://docs.massa.net/" | |||
| execution-trace = ["serde_json"] | |||
| dump-block = [] | |||
| test-exports = [] | |||
| execution-info = ["execution-trace"] | |||
There was a problem hiding this comment.
shouldn't we also add "massa_execution_exports/execution-info"? (or "massa_execution_exports/execution-trace", not sure).
Because in public.rs, we import types that are only valid if "massa_execution_exports/execution-trace" is set, so building this package separately fails (cargo check --package massa_grpc --features execution-info)
| None, | ||
| None, | ||
| None, | ||
| None, |
There was a problem hiding this comment.
we don't provide other info here? (the operation_id where the register was done?)
| (CoinOrigin::Slash as i32, None, None, None, None) | ||
| } | ||
| TransferContext::CreateSCStorage => { | ||
| (CoinOrigin::CreateScStorage as i32, None, None, None, None) |
There was a problem hiding this comment.
same for here and below, can't we get the operation id?
resync_checkflag