Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #607

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #607

wants to merge 6 commits into from

Conversation

lthmslf
Copy link

@lthmslf lthmslf commented Feb 9, 2025

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add hover effects for all clickable elements on the page, example for buttons, links, images

  2. Change the autofill styles for input

image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. Fix this error after submit the form
image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to limit width of those elements
image

you can just use
grid-template-columns: repeat(2, 1fr);
and add some padding

@lthmslf lthmslf requested a review from etojeDenys February 13, 2025 19:00
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know if removing scroll bar is bug or feature, but it looks nice, lets consider its feature)
Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants