Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #613

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

solution #613

wants to merge 4 commits into from

Conversation

Bukavyna
Copy link

etojeDenys
etojeDenys suggested changes Feb 16, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need those spaces
image
image
image
image

  1. its should be the links with some hover
image
  1. you don't need those spaces here too, just stretch the content
image

@Bukavyna Bukavyna requested a review from etojeDenys March 25, 2025 16:27
etojeDenys
etojeDenys suggested changes Mar 25, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. we should stretch this image on full width
image same here image
  1. should be links
image
  1. looks weird on large screens
image

@Bukavyna Bukavyna requested a review from etojeDenys March 26, 2025 16:39
etojeDenys
etojeDenys approved these changes Mar 26, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, but still it's better to add hovers to all links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bukavyna @etojeDenys