Skip to content

create landing page Museum #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

create landing page Museum #615

wants to merge 3 commits into from

Conversation

OlehYavoriv
Copy link

volodymyr-soltys97
volodymyr-soltys97 suggested changes Feb 19, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Need to fix background color when menu is open
image
  1. Also remove scroll on the page when menu is open

maxim2310
maxim2310 suggested changes Feb 19, 2025
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done

  1. menu should be closed after click on any link
    image
  2. looks a bit cut
    image

@OlehYavoriv
Copy link
Author

OlehYavoriv commented Feb 19, 2025 •
edited
Loading

@maxim2310
Sure, i fixed some errors with aside menu (close menu when i click on a navigation link) [1].

But, idk the burger menu icon looks right in my localhost and demo version [2].

Знімок екрана 2025-02-19 о 11 07 35 Знімок екрана 2025-02-19 о 11 07 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@maxim2310 maxim2310 Awaiting requested review from maxim2310

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlehYavoriv @volodymyr-soltys97 @etojeDenys @maxim2310